allow dynamic updates to type mapping, update README #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
auto_discover_type_mapping
branch
from
aec3a83 to
81dbb3c
Compare
missinglink
force-pushed
the
auto_discover_type_mapping
branch
4 times, most recently
from
7b538c2 to
d751225
Compare
missinglink
changed the title
…to the type mapping to continue functioning after update
missinglink
force-pushed
the
auto_discover_type_mapping
branch
from
d751225 to
79875b3
Compare
orangejulius
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Looks good overall, nice solution to the dynamic update problem, and overall this cleans up the code a bit (looking at it now I really didn't like how just one property from the type_mapping object was passed to some sanitizers.
I have some thoughts on the readme wording but otherwise 👍
| @@ -11,7 +11,7 @@ module.exports.middleware = (_api_pelias_config) => { | |||
| size: require('../sanitizer/_size')(/* use defaults*/), | |||
| layers: require('../sanitizer/_targets')('layers', type_mapping.layer_mapping), | |||
| sources: require('../sanitizer/_targets')('sources', type_mapping.source_mapping), | |||
| address_layer_filter: require('../sanitizer/_address_layer_filter')(type_mapping.layers_by_source), | |||
| address_layer_filter: require('../sanitizer/_address_layer_filter')(type_mapping), | |||
There was a problem hiding this comment.
nice, this is way cleaner.
|
Actioned PR feedback in 091b1ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was written with the notion that the 'type mapping' would be static, so in some cases, the
setup()function was pre-processing the source/layer mapping in order to cache the values.This would result in incorrect behaviour for sources/layers where the new values set by
auto_discoverwere not being used.This PR removes any pre-processing of the sources/layers and also uses a new function which ensures that existing pointer references are kept up-to-date.